Add RO:0018042 has gene product that enables #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitacaron
reviewed
Nov 4, 2025
anitacaron
reviewed
Nov 4, 2025
anitacaron
requested changes
Nov 4, 2025
Collaborator
anitacaron
left a comment
anitacaron
left a comment
There was a problem hiding this comment.
Please check the comments.
cthoyt
force-pushed
the
gene-product-enables
branch
from
a876cfc to
45c8efe
Compare
Collaborator
Author
|
@anitacaron I addressed both and rebased against the main branch |
anitacaron
previously approved these changes
Nov 4, 2025
Collaborator
anitacaron
left a comment
anitacaron
left a comment
There was a problem hiding this comment.
Technically, it's approved, but still needs an ontologist reviewer.
balhoff
requested changes
Jan 12, 2026
Member
balhoff
left a comment
balhoff
left a comment
There was a problem hiding this comment.
@cthoyt makes sense to me! I suggest making this property a subproperty of functionally related to.
cthoyt
force-pushed
the
gene-product-enables
branch
from
f7cca80 to
c36f009
Compare
Collaborator
Author
|
@balhoff thanks for the quick review, I did that then rebased my changes on the main branch |
balhoff
approved these changes
Jan 12, 2026
Collaborator
Author
|
@anitacaron does this need additional discussion before merge, now that Jim has commented and I've updated it accordingly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #873
I want to model the relationship between a gene and its product's molecular function.
graph LR gene["AKT1 (HGNC:391)"] -- "has gene product (RO:0002205)" --> protein["RAC-alpha serine/threonine-protein kinase (uniprot:P31749)"] -- "enables (RO:0002327)" --> activity["non-specific serine/threonine protein kinase (EC:2.7.11.1)"] gene -- "has gene product that enables (this proposal)" --> activityI see this as being a simple property chain of has gene product (RO:0002205) and enables (RO:0002327). As suggested by @balhoff, this property is a sub-property of the grouping property "functionally related to"
Further discussion about EC/Rhea/GO being molecular functions in #783
Motivation
This is directly motivated by making a more accurate ontologization of HGNC in biopragmatics/pyobo#455