Reject pending promises when a generator is closed #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats an issue raised here observablehq/runtime#376
V6 runtime will wait for prior promises to resolve, in the case of a generator like Generator.input, the initial value will wait for a truthy value, if the cell is invalidated, the initial value will never be resolved and the runtime is stuck.
In this change we reject any pending promises when a Generator is disposed, ensuring nothing gets hung. By rejecting we ensure nothing interprets this as an actual value.
I can confirm this fixes a behaviour I was observing when running Notebook 1.0 on Runtime v6.0