Add an Option to Insert Checkboxes on Empty Lines #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the type annotation for create_on_empty docs: updated CHANGELOG and README with checkbox features
…arc.json I think this will only be relevant on my machine, since it must've been working for other contributors beforehand. I don't really know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added an option that causes the toggle_checkbox command to work on empty lines, as it functions in Obsidian. #351
Testing
I saw that all the other tests for checkboxes are broken currently and I didn't want to wade into that so I didn't write any.
Documentation
updated
CHANGELOG.md, but it was out of date, see #354updated
README.mdwith my changes and the existing options that were not documented thereNote on
make choresFor some reason I had to change the
luarc.jsonfile to explicitly reference the luv library, I'm guessing this is just an issue on my machine and doesn't need to be pulled into the main repo but I don't really understand what's going on there.PR Checklist
CHANGELOG.mdis updatedREADME.mdfilemake chores(for style, lint, types, and tests) See the above note