test: Use createSorterFromLine() instead of parseSortLine() in tests

This is preparation for removing parseSortLine(), which is effectively
a duplicate of createSorterFromLine()

Author: claremacrae

tests/Query/Filter/Field.test.ts

@@ -62,7 +62,6 @@ describe('sorting - base class usability and implementation', () => {
         });
 
         it('should fail to parse a "valid" line', () => {
-            // expect(unsupported.parseSortLine('sort by unsupported')).toThrow(Error);
             const line = 'sort by unsupported';
             expect(unsupported.createSorterFromLine(line)).toBeNull();
             const sorting = unsupported.parseSortLine(line);
@@ -97,7 +96,7 @@ describe('sorting - base class usability and implementation', () => {
         });
 
         it('should compare two tasks', () => {
-            const sorting = supported.parseSortLine('sort by description-length');
+            const sorting = supported.createSorterFromLine('sort by description-length');
             const a = new TaskBuilder().description('short description').build();
             const b = new TaskBuilder().description('very looooooooong description').build();
             expectTaskComparesBefore(sorting!, a, b);

tests/Query/Filter/RecurringField.test.ts

@@ -60,7 +60,7 @@ describe('sorting by recurring', () => {
 
     it('parses sort by recurrence', () => {
         const field = new RecurringField();
-        expect(field.parseSortLine('sort by recurring')).not.toBeNull();
+        expect(field.createSorterFromLine('sort by recurring')).not.toBeNull();
     });
 
     it('sort by due', () => {

tests/Query/Filter/TagsField.test.ts

@@ -362,20 +362,20 @@ describe('Sort by tags', () => {
         });
 
         it('should parse a valid line with default tag number', () => {
-            const sorter = tagsField.parseSortLine('sort by tag');
+            const sorter = tagsField.createSorterFromLine('sort by tag');
             expect(sorter?.property).toEqual('tag');
             expect(sorter?.comparator(tag_a, tag_b)).toBeLessThan(0);
             expectTaskComparesBefore(sorter!, tag_a, tag_b);
         });
 
         it('should parse a valid line with a non-default tag number', () => {
-            const sorter = tagsField.parseSortLine('sort by tag 2');
+            const sorter = tagsField.createSorterFromLine('sort by tag 2');
             expect(sorter?.property).toEqual('tag');
             expectTaskComparesBefore(sorter!, tags_a_b, tags_a_c);
         });
 
         it('should parse a valid line with reverse and a non-default tag number', () => {
-            const sorter = tagsField.parseSortLine('sort by tag reverse 2');
+            const sorter = tagsField.createSorterFromLine('sort by tag reverse 2');
             expect(sorter?.property).toEqual('tag');
             expectTaskComparesAfter(sorter!, tags_a_b, tags_a_c);
         });
@@ -417,7 +417,10 @@ describe('Sort by tags', () => {
 
         // Act / Assert
         expect(
-            Sort.by([new TagsField().parseSortLine('sort by tag 1')!], [t1, t3, t5, t7, t6, t4, t2, t8, t9, t10]),
+            Sort.by(
+                [new TagsField().createSorterFromLine('sort by tag 1')!],
+                [t1, t3, t5, t7, t6, t4, t2, t8, t9, t10],
+            ),
         ).toEqual(expectedOrder);
     });
 
@@ -438,7 +441,7 @@ describe('Sort by tags', () => {
         // Act / Assert
         expect(
             Sort.by(
-                [new TagsField().parseSortLine('sort by tag reverse 1')!],
+                [new TagsField().createSorterFromLine('sort by tag reverse 1')!],
                 [t1, t3, t5, t7, t6, t4, t2, t8, t9, t10],
             ),
         ).toEqual(expectedOrder);
@@ -451,7 +454,9 @@ describe('Sort by tags', () => {
         const t4 = fromLine({ line: '- [ ] a #iii #ddd' });
         const t5 = fromLine({ line: '- [ ] a #hhh #eee' });
         const expectedOrder = [t1, t2, t3, t4, t5];
-        expect(Sort.by([new TagsField().parseSortLine('sort by tag 2')!], [t4, t3, t2, t1, t5])).toEqual(expectedOrder);
+        expect(Sort.by([new TagsField().createSorterFromLine('sort by tag 2')!], [t4, t3, t2, t1, t5])).toEqual(
+            expectedOrder,
+        );
     });
 
     it('should sort correctly reversed by second tag with no global filter', () => {
@@ -461,7 +466,7 @@ describe('Sort by tags', () => {
         const t4 = fromLine({ line: '- [ ] a #iii #ddd' });
         const t5 = fromLine({ line: '- [ ] a #hhh #eee' });
         const expectedOrder = [t5, t4, t3, t2, t1];
-        expect(Sort.by([new TagsField().parseSortLine('sort by tag reverse 2')!], [t4, t3, t2, t1, t5])).toEqual(
+        expect(Sort.by([new TagsField().createSorterFromLine('sort by tag reverse 2')!], [t4, t3, t2, t1, t5])).toEqual(
             expectedOrder,
         );
     });
@@ -489,7 +494,7 @@ describe('Sort by tags', () => {
         // Act
         expect(
             Sort.by(
-                [new TagsField().parseSortLine('sort by tag 1')!],
+                [new TagsField().createSorterFromLine('sort by tag 1')!],
                 [t1, t12, t3, t13, t5, t7, t6, t4, t2, t8, t9, t10, t11],
             ),
         ).toEqual(expectedOrder);
@@ -521,7 +526,7 @@ describe('Sort by tags', () => {
         // Act
         expect(
             Sort.by(
-                [new TagsField().parseSortLine('sort by tag reverse 1')!],
+                [new TagsField().createSorterFromLine('sort by tag reverse 1')!],
                 [t1, t12, t3, t13, t5, t7, t6, t4, t2, t8, t9, t10, t11],
             ),
         ).toEqual(expectedOrder);
@@ -545,7 +550,10 @@ describe('Sort by tags', () => {
         const expectedOrder = [t1, t2, t3, t4, t5, t6, t7, t8];
 
         // Act
-        const result = Sort.by([new TagsField().parseSortLine('sort by tag 2')!], [t4, t7, t5, t2, t3, t1, t8, t6]);
+        const result = Sort.by(
+            [new TagsField().createSorterFromLine('sort by tag 2')!],
+            [t4, t7, t5, t2, t3, t1, t8, t6],
+        );
 
         // Assert
         expect(result).toEqual(expectedOrder);
@@ -570,7 +578,7 @@ describe('Sort by tags', () => {
 
         // Act
         const result = Sort.by(
-            [new TagsField().parseSortLine('sort by tag reverse 2')!],
+            [new TagsField().createSorterFromLine('sort by tag reverse 2')!],
             [t4, t7, t5, t2, t3, t1, t8, t6],
         );
 
@@ -608,8 +616,8 @@ describe('Sort by tags', () => {
         expect(
             Sort.by(
                 [
-                    new TagsField().parseSortLine('sort by tag 2')!, // tag 2 - ascending
-                    new TagsField().parseSortLine('sort by tag 1')!, // tag 1 - ascending
+                    new TagsField().createSorterFromLine('sort by tag 2')!, // tag 2 - ascending
+                    new TagsField().createSorterFromLine('sort by tag 1')!, // tag 1 - ascending
                     new DescriptionField().createNormalSorter(), // then description - ascending
                 ],
                 input,