refactor: Inline Field.parseSortLine()

Replace remaining parseSortLine() calls with createSorterFromLine()

Author: claremacrae

src/Query/Filter/Field.ts

@@ -131,20 +131,6 @@ export abstract class Field {
         return false;
     }
 
-    /**
-     * Parse a 'sort by' line and return a {@link Sorter} object.
-     *
-     * Returns null line does not match this field or is invalid,
-     * or this field does not support sorting.
-     */
-    public parseSortLine(line: string): Sorter | null {
-        if (!this.supportsSorting()) {
-            return null;
-        }
-
-        return this.createSorterFromLine(line);
-    }
-
     /**
      * Parse the line, and return either a {@link Sorter} object or null.
      *

src/Query/FilterParser.ts

@@ -81,7 +81,7 @@ export function parseSorter(sorterString: string): Sorter | null {
     // See if any of the fields can parse the line.
     for (const creator of fieldCreators) {
         const field = creator();
-        const sorter = field.parseSortLine(sorterString);
+        const sorter = field.createSorterFromLine(sorterString);
         if (sorter) {
             return sorter;
         }

tests/Query/Filter/Field.test.ts

@@ -63,8 +63,7 @@ describe('sorting - base class usability and implementation', () => {
 
         it('should fail to parse a "valid" line', () => {
             const line = 'sort by unsupported';
-            expect(unsupported.createSorterFromLine(line)).toBeNull();
-            const sorting = unsupported.parseSortLine(line);
+            const sorting = unsupported.createSorterFromLine(line);
             expect(sorting).toBeNull();
         });
     });
@@ -82,16 +81,14 @@ describe('sorting - base class usability and implementation', () => {
 
         it('should parse a valid line', () => {
             const line = 'sort by description-length';
-            expect(supported.createSorterFromLine(line)).not.toBeNull();
-            const sorting = supported.parseSortLine(line);
+            const sorting = supported.createSorterFromLine(line);
             expect(sorting).not.toBeNull();
             expect(sorting?.property).toEqual('description-length');
         });
 
         it('should fail to parse a invalid line', () => {
             const line = 'sort by jsdajhasdfa';
-            expect(supported.createSorterFromLine(line)).toBeNull();
-            const sorting = supported.parseSortLine(line);
+            const sorting = supported.createSorterFromLine(line);
             expect(sorting).toBeNull();
         });
 

tests/Query/Filter/TagsField.test.ts

@@ -395,8 +395,7 @@ describe('Sort by tags', () => {
 
         it('should fail to parse a invalid line', () => {
             const line = 'sort by jsdajhasdfa';
-            expect(tagsField.createSorterFromLine(line)).toBeNull();
-            const sorting = tagsField.parseSortLine(line);
+            const sorting = tagsField.createSorterFromLine(line);
             expect(sorting).toBeNull();
         });
     });