Use github actions/workflows to build plugin assets (main.js & manifest.json)#68
Use github actions/workflows to build plugin assets (main.js & manifest.json)#68mwoz123 wants to merge 6 commits intoobsidianmd:masterfrom
main.js & manifest.json)#68Conversation
mwoz123
changed the title
main.js & manifest.json)
There was a problem hiding this comment.
I'm not sure that I understand the value of uploading the build artifacts to GitHub action artifacts. Automating a full release seems more in line with what the Obsidian team asks for releasing so I opened #72
If you think there is something missing from that action that yours has let me know and I'll gladly add it
|
Well, as there was no CI (to be clear I'm not an expert here;)) but wanted to share it as this could be a starting point to automate. How about closing this one and adding to your PR create of artifacts (line 32-38 on my PR) as this is useful for tests on mobile (maybe with a retention period if required)? |
|
Good call! Having the artifacts from build would be useful for mobile. Would you like to fork https://github.com/Ebonsignori/obsidian-sample-plugin/tree/master and make a commit or would you like me to add it to my branch? |
|
Please just add it to your branch ;) |
|
Done! |
|
Closed in favor of #72 |
|
Reopeining as #72 still doesn't handle that. |
2 participants
Make usage of GitHub Actions to build plugin (after push) and produce plugin zip artifacts containinig
main.js&manifest.jsonas on screenshot below:
