Cleanup / refactor parsing in operations.c#108
Open
matthewbauer wants to merge 2 commits intodevelopfrom
Open
Conversation
Collaborator
matthewbauer
commented
Nov 13, 2019
matthewbauer
commented
- Throw parse error when bool is neither 0x00 or 0xff
- Add ASSERT_EQ macro to src/operations.c
Tezos docs say that booleans must be either 0x00 (false) or 0xff (true). This change throws a parse error when those values are outside those two values.
This makes the Michelson parsing code clearer. Basic function is to error when two values are not equal to each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.