This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Introduce Temporal to handle date and time #1003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input event handler call to DateInput Shift to local DateInput component Reserve submitting null when no cache Simplified date / datetime input Clean up
Stage 1: Handle most views and sorts, except for calendar
Seems buggy, needs unit test to calendar helpers
Write date string back according to timezone Only reserve non-local timezone marks, non-DST save. Possible solution should be providing settings to specify user zone Add hint Resume input events on date inputs Extend date string support for timezoneId Fix date parsing Remove dayjs Cancel default date filling in field creation Refactor date string parsing Clean up redundant comments and tests Fix bugs on filters and card display Fix calendar date range Refactor calendar with Temporal Seems buggy, needs unit test to calendar helpers Refactor using Temporal Stage 1: Handle most views and sorts, except for calendar
Collaborator
Author
|
@marcusolsson Hi! Since this is a significant change, could you take some time to review the design? In short, I’m converting all date/datetime strings into For edits in the Projects UI, only values with a different timezone offset from the user’s local zone will retain the offset suffix. For example, if the user’s timezone is
Update: Continue at #1004, I messed up resolving conflicts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994, #974
Possibly to close #430 if plugin-specified locale settings are required
May fix #969 together if the date field detection is enhanced
Currently in alpha stage, the PRs works but has bugs