network: Check max recommended bitrate from service

[prgmitchell]

Description

This adds a warning if the maximum recommended video bitrate from the selected service has been exceeded.

Requires obsproject/obs-studio#10917 to be merged first.

Motivation and Context

Added logging to OBS to display max bitrate when the user elects to ignore the service recommendations, this brings that to the analyzer as well.

How Has This Been Tested?

Tested with this log https://obsproject.com/logs/ZuadI85OgoP0Yjjj

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[RytoEX]

Looks like #11733 (the replacement for #10917) was merged, so this can be undrafted. This will require a rebase.

[prgmitchell]

@RytoEX updated, seems to be working fine

The build is failing though, looks like the test it runs is pointing at a log file that no longer exists.

[Warchamp7]

@RytoEX updated, seems to be working fine
The build is failing though, looks like the test it runs is pointing at a log file that no longer exists.

#183 is to fix that

[Fenrirthviti]

Just for my reference, this warning only shows if the ignore recommendations option is enabled, and it's actually sending over the service's configured limit from services.json?

[prgmitchell]

Just for my reference, this warning only shows if the ignore recommendations option is enabled, and it's actually sending over the service's configured limit from services.json?

Correct