Skip to content

Conversation

@Penwy
Copy link
Contributor

@Penwy Penwy commented Sep 15, 2025

Description

This updates the encoders detection in the log to the current obs encoder names, and does minor syntax readability touch-ups on those checks.

Motivation and Context

Encoder detection wasn't working with current encoders due to name changes.

How Has This Been Tested?

Ran it on varied logs, verified it properly worked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested a review from Fenrirthviti September 17, 2025 19:21
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Updated the encoder names that have since changed
- Added software AV1 encoders detection
- Fixed up syntax for better readability
W503 and W504 are contrary to each other and their current coexistence is due
to a pending rule change. One should be ignored to allow proper linebreaks in
long operator sequences. According to current conventions, W503 should be
disabled for future-proof linebreaking.
@RytoEX RytoEX merged commit 4f74875 into obsproject:master Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants