-
-
Notifications
You must be signed in to change notification settings - Fork 9k
libobs/graphics: Add float2x2 and float3x3 support #10323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| gl_success("glUniform4fv"); | ||
| } | ||
|
|
||
| } else if (pp->param->type == GS_SHADER_PARAM_MATRIX3X3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't add a matrix2x2 parameter handler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a struct matrix2 yet, I don't need it and see it as outside of the scope of this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of matrix2x2 parameters in this pull request, if its not to enable passing a matrix2x2 parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request helps obs-shaderfilter detecting types used so that it can provide better guidance on how to make the shader work for OBS.
|
One thing I wanted to note is that your motivation/context section should try to make sure to specify why you're adding a feature or want a feature you're submitting in the motivation/context, such as something specific you're building or something specific you're trying to do. It's good to have the full context and motivation behind a change. If you've already specified it in another PR or issue, then you can just link to that prior PR/issue where motivation was specified. |
|
There's two issues with this PR, one conceptual, the other architectural:
Functionality is implemented primarily with an eye towards OBS Studio's own needs, with plugins being downstream from that. And given OBS Studio's complexity (and the mountain of open issues and tech debt) it's important for the project to focus on changes and additions that make that mountain smaller first. Changing
If we were to accept support for two matrix types that aren't even used by OBS itself, then that support needs to be complete: All related functions in all graphics APIs (Direct3D, OpenGL, and Metal) for all added types need to be implemented. |
Description
Add float2x2 and float3x3 support
Motivation and Context
Support more for shaders. This pull request helps obs-shaderfilter detecting types used so that it can provide better guidance on how to make the shader work for OBS.
How Has This Been Tested?
On windows 64 by loading shaders with these types.
Types of changes
Checklist: