Open
Conversation
tatchi
commented
Feb 10, 2023
| show Omd.Ctor.[ h 6 [ txt "Heading 6"; em "with emphasis!" ] ]; | ||
| [%expect | ||
| {| <h6 id="heading-6with-emphasis">Heading 6<em>with emphasis!</em></h6> |}] | ||
| {| <h6>Heading 6<em>with emphasis!</em></h6> |}] |
Collaborator
Author
There was a problem hiding this comment.
I think that's a side effect of the new implementation. Since we now add the auto-ids at the time we parse the document, there's no way to have them auto-included here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
This moves the auto identifiers logic into the AST (when parsing the document). It moves the
auto_identifiersparameter from theOmd.to_htmlfunction to theOmd.{of_channel,of_string}function.I'm not sure if this API is ideal because it means that we have to parse a document twice (once with
auto_identifiersset totrueand once withfalse) if we want to print it with/without auto-identifiers.Perhaps including the auto-ids in the AST and deciding whether or not to include them at the time of printing would be a better solution.
The only problem is that we'd need to distinguish an explicit id from an auto-generated one in the AST.