Don't install unstable versions by default#21
Conversation
gridbugs
force-pushed
the
avoid-unstable-versions-by-default
branch
2 times, most recently
from
1e10eb4 to
f2bdc9a
Compare
install.sh
Outdated
| echo | ||
| elif [ "$allow_unstable" = "1" ]; then | ||
| echo | ||
| error "--allow-unstable has no impact when version number is explicitly specified" |
There was a problem hiding this comment.
I'm a bit confused by this -- does it mean if I want to install an older unstable version, I just need to specify it in the version and don't need the --allow-unstable flag?
There was a problem hiding this comment.
If you don't pass the install script a version number then it will install the latest version of dune. This flag allows the installer to consider unstable versions of dune when choosing the latest version. If you want to install an specific unstable version of dune you can always do so by passing that version to the script explicitly though. Perhaps we should just prevent the script from automatically choosing an unstable version altogether rather than providing that behaviour behind a flag. What do you think?
There was a problem hiding this comment.
I've updated this PR to not have an --allow-unstable flag, and instead just always choose the the latest stable version when the version number is omitted.
There was a problem hiding this comment.
That sounds good to me! Should we document somewhere that a user needs to explicitly specify the version if they want to install an unstable version?
There was a problem hiding this comment.
I added some info to the usage string.
gridbugs
force-pushed
the
avoid-unstable-versions-by-default
branch
2 times, most recently
from
e57acea to
31d4df6
Compare
When the install is run with no arguments it will install the latest version of dune with a binary release. Prior to this change this included unstable versions of dune such as 3.20.0_alpha4. This changes the behaviour to only consider versions whose version numbers look stable. Also adds some additional options to make it possible to test this change on a fictional set of released versions of dune as at the time of writing there is only one stable and one unstable version released. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
avoid-unstable-versions-by-default
branch
from
31d4df6 to
4e211e0
Compare
2 participants
When the install is run with no arguments it will install the latest version of dune with a binary release. Prior to this change this included unstable versions of dune such as 3.20.0_alpha4. This changes the default behaviour to only consider versions whose version numbers look stable and introduces a flag to allow unstable versions to be considered also.
Also adds some additional options to make it possible to test this change on a fictional set of released versions of dune as at the time of writing there is only one stable and one unstable version released.