This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Add shell script that builds dune and makes tarball#12
Merged
gridbugs merged 1 commit intoocaml-dune:mainfrom Aug 12, 2025
Merged
Add shell script that builds dune and makes tarball#12gridbugs merged 1 commit intoocaml-dune:mainfrom
gridbugs merged 1 commit intoocaml-dune:mainfrom
Conversation
gridbugs
force-pushed
the
make-tarball-script
branch
7 times, most recently
from
88df2e4 to
fbedf11
Compare
shonfeder
approved these changes
Aug 12, 2025
Comment on lines
+8
to
+11
| echo "TARGET is the nix target that gets built. It should be one of:" | ||
| echo " - .#dune.dynamic (builds a dynamically-linked dune executable)" | ||
| echo " - .#dune.static (builds a statically-linked dune executable)" | ||
| exit 1 |
Member
There was a problem hiding this comment.
For my own edification, where is the logic that will actually make this decision based on the value of TARGET? Searching this repo for those strings didn't seem to turn anything up for me.
Contributor
Author
There was a problem hiding this comment.
It's in the github action in the file .github/workflows/build.yml.
Member
There was a problem hiding this comment.
Oh yes. That I saw. Perhaps that intended usage shoukd be noted here then? There is nothing about this script itself as is that lets readers of the file know it has a coupling like that with the GitHub workflow.
gridbugs
force-pushed
the
make-tarball-script
branch
3 times, most recently
from
70b4014 to
4f13911
Compare
This makes it easier to test the binary distro offline since the tarball has the same logic as the release github action (which now just runs the script). This also makes it more reliable to test the build and packaging process since the script can be run from a test setting, so this change also introduces a github action that runs such a test. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
make-tarball-script
branch
from
4f13911 to
973c8e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to test the binary distro offline since the tarball has the same logic as the release github action (which now just runs the script). This also makes it more reliable to test the build and packaging process since the script can be run from a test setting, so this change also introduces a github action that runs such a test.