This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Merged
Conversation
gridbugs
force-pushed
the
posix-shell-env-file
branch
from
8ccd026 to
633255a
Compare
gridbugs
changed the title
gridbugs
force-pushed
the
posix-shell-env-file
branch
2 times, most recently
from
270efae to
27a45ab
Compare
shonfeder
approved these changes
Aug 12, 2025
.github/workflows/test.yml
Outdated
Comment on lines
+16
to
+17
| # exclude warning for sourcing missing external file | ||
| shellcheck --exclude=SC1091 extra/share/dune/env/env.sh extra/share/dune/env/env.bash |
Member
There was a problem hiding this comment.
Should the warning be excluded rather in the script itself, to also spare devs the noise locally? Or is there a reason for a disparity between the dev environment and what the CI sees?
Contributor
Author
There was a problem hiding this comment.
I didn't realize that was a possibility. Will update!
This amounted taking the bash env script and removing its use of the `local` keyword and changing is extension to ".sh". The posix env script also doesn't source the bash completion script as it uses some bash-specific features. This allows the dune binary distro to be used on machines with minimal shells such as the ash shell in the default environment on alpine linux. Also adds a test that runs shellcheck on env.sh to make sure it stays posix-compatible. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
posix-shell-env-file
branch
from
27a45ab to
5b45399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This amounted taking the bash env script and removing its use of the
localkeyword and changing is extension to ".sh".This allows the dune binary distro to be used on machines with minimal shells such as the ash shell in the default environment on alpine linux.
Also adds a test that runs shellcheck on env.sh to make sure it stays posix-compatible.