Update make release for dune-release.2.0.0#22
Open
mbarbin wants to merge 1 commit intoocaml-dune:masterfrom
Open
Update make release for dune-release.2.0.0#22mbarbin wants to merge 1 commit intoocaml-dune:masterfrom
mbarbin wants to merge 1 commit intoocaml-dune:masterfrom
Conversation
Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
Collaborator
Author
|
Note that the new version Nowadays, the recommendation is to simply point users to the documentation in In the light of the Objections? |
Collaborator
Author
|
TODO: investigate what further updates are required to use the latest |
Contributor
|
No objections from me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While cutting the release 2.0.0 I noticed a few things that needs updating in the
make releasescript.-nwas renamed. I removed it,dune-releaseis now able to determine the package name from the opam file found at the root;gh-pagesbranch, I added the corresponding entry (publish doc)As it stands, I believe the release sequence is very close to what
dune-releasedoes by default when invoked without arguments, but keeping the entries as a sequence allows to trouble shoot if a step fails, doing some sanity checks along the way, etc.