Skip to content

Commit e948fa7

Browse files
authored
Merge pull request #592 from dra27/clarify-config
Clarify configuration for lib_eio_linux and enable tests on other arches
2 parents 432e103 + d5ebfd4 commit e948fa7

File tree

2 files changed

+34
-10
lines changed

2 files changed

+34
-10
lines changed

lib_eio_linux/dune

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
(name eio_linux)
33
(public_name eio_linux)
44
(enabled_if ; See https://github.com/ocaml/dune/issues/4895
5-
(or (= %{system} "linux") ; Linux-x86
6-
(= %{system} "linux_eabihf") ; Linux-arm32
7-
(= %{system} "linux_elf") ; Linux-x86_32
8-
(= %{system} "elf"))) ; Linux-ppc64
5+
(or (= %{system} "linux") ; Historically, just Linux-x86
6+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
7+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
8+
(= %{system} "elf"))) ; Historically, Linux-ppc64
99
(foreign_stubs
1010
(language c)
1111
(flags :standard -D_LARGEFILE64_SOURCE)

lib_eio_linux/tests/dune

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,59 @@
11
(library
22
(name eurcp_lib)
3-
(enabled_if (= %{system} "linux"))
3+
(enabled_if ; See https://github.com/ocaml/dune/issues/4895
4+
(or (= %{system} "linux") ; Historically, just Linux-x86
5+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
6+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
7+
(= %{system} "elf"))) ; Historically, Linux-ppc64
48
(modules eurcp_lib)
59
(libraries eio_linux))
610

711
(executable
812
(name eurcp)
9-
(enabled_if (= %{system} "linux"))
13+
(enabled_if ; See https://github.com/ocaml/dune/issues/4895
14+
(or (= %{system} "linux") ; Historically, just Linux-x86
15+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
16+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
17+
(= %{system} "elf"))) ; Historically, Linux-ppc64
1018
(modules eurcp)
1119
(libraries cmdliner logs.cli logs.fmt fmt.tty fmt.cli eurcp_lib))
1220

1321
(executable
1422
(name basic_eio_linux)
15-
(enabled_if (= %{system} "linux"))
23+
(enabled_if ; See https://github.com/ocaml/dune/issues/4895
24+
(or (= %{system} "linux") ; Historically, just Linux-x86
25+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
26+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
27+
(= %{system} "elf"))) ; Historically, Linux-ppc64
1628
(modules basic_eio_linux)
1729
(libraries logs.fmt fmt.tty eurcp_lib))
1830

1931
(executables
2032
(names bench_noop)
21-
(enabled_if (= %{system} "linux"))
33+
(enabled_if ; See https://github.com/ocaml/dune/issues/4895
34+
(or (= %{system} "linux") ; Historically, just Linux-x86
35+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
36+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
37+
(= %{system} "elf"))) ; Historically, Linux-ppc64
2238
(modules bench_noop)
2339
(libraries eio_linux))
2440

2541
(test
2642
(name test)
2743
(package eio_linux)
28-
(build_if (= %{system} "linux"))
44+
(build_if ; See https://github.com/ocaml/dune/issues/4895
45+
(or (= %{system} "linux") ; Historically, just Linux-x86
46+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
47+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
48+
(= %{system} "elf"))) ; Historically, Linux-ppc64
2949
(modules test)
3050
(libraries alcotest eio_linux))
3151

3252
(mdx
3353
(package eio_linux)
34-
(enabled_if (= %{system} "linux"))
54+
(enabled_if ; See https://github.com/ocaml/dune/issues/4895
55+
(or (= %{system} "linux") ; Historically, just Linux-x86
56+
(= %{system} "linux_eabihf") ; Historically, Linux-arm32
57+
(= %{system} "linux_elf") ; Historically, Linux-x86_32
58+
(= %{system} "elf"))) ; Historically, Linux-ppc64
3559
(deps (package eio_linux)))

0 commit comments

Comments
 (0)