Support chmod in Eio_linux and Eio_posix#785
Draft
patricoferris wants to merge 5 commits intoocaml-multicore:mainfrom
Draft
Support chmod in Eio_linux and Eio_posix#785patricoferris wants to merge 5 commits intoocaml-multicore:mainfrom
chmod in Eio_linux and Eio_posix#785patricoferris wants to merge 5 commits intoocaml-multicore:mainfrom
Conversation
patricoferris
force-pushed
the
fchmodat2
branch
from
9873fb6 to
d25bfbf
Compare
Co-Authored-By: Daniel Ntege <itsupport@bugemauniv.ac.ug>
patricoferris
force-pushed
the
fchmodat2
branch
from
d25bfbf to
5068db1
Compare
Collaborator
Author
|
It seems |
Collaborator
|
Changing |
talex5
reviewed
Dec 3, 2024
| C.C_define.import c ~c_flags | ||
| ~includes:["fcntl.h"] | ||
| C.C_define.Type.[ | ||
| "AT_SYMLINK_NOFOLLOW", Int; |
Collaborator
There was a problem hiding this comment.
You can get this from uring I think (Statx.Flags.symlink_nofollow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a tidied up version of #772
I'm not really sure what to do on Windows --
Unix.chmoddoes use_wchmodbut the Unix-y permissions don't really make much sense on Windows afaict. Perhaps this isn't a problem for this PR.