Switch selection of GLPK to Dune virtual libraries#24
Draft
dra27 wants to merge 3 commits intoocaml-opam:masterfrom
Draft
Switch selection of GLPK to Dune virtual libraries#24dra27 wants to merge 3 commits intoocaml-opam:masterfrom
dra27 wants to merge 3 commits intoocaml-opam:masterfrom
Conversation
05a9e93 to
4a348c7
Compare
|
Any plan to continue this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work in #22 to make the vendored GLPK completely separate from the forked MCCS. This takes advantage of the Dune virtual libraries introduced in version 1.7 of the language (the implementation details for MCCS mean that Dune 1.9.2 or later is required).
Various notes:
src/glpk-static/duneandsrc/glpk-shared/dunemust be blown away before the build (seemccs.opamand the temporary steps inappveyor.yml)default_implementationfield to mean thatopamcarries on using the internal solver by default - downstream builds such as Debian can in future altersrc/solver/dunein opam to changemccstomccs.shared.context_flags.mlandcontext_flags_all.mlshould be merged and tidied up. The git diff appears to have got thoroughly confused by the renaming - they're basically unchanged!