add a Pattern constructor to Extended_ast.t#2644
Merged
Julow merged 5 commits intoocaml-ppx:mainfrom Feb 18, 2025
Merged
Conversation
So it's easier to print patterns, which seems like the main major syntactic category missing from the type. Granted, no standard source file contains a pattern, but the same argument applies to core_type.
v-gb
force-pushed
the
push-rkmlumkyttqt
branch
from
4bb8bf6 to
a4ad9ec
Compare
Julow
added
the
no changelog
Contributor
Author
|
Thanks! |
davesnx
pushed a commit
to ocaml-mlx/ocamlformat-mlx
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it's easier to print patterns, which seems like the main major syntactic category missing from the sum type.
I think the only way to print pattern otherwise is to print a
fun $pat -> whatevernode and chop off the unwanted bits of the string.