Skip to content

makes exp-grouping=preserve the default #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

makes exp-grouping=preserve the default #2716

wants to merge 2 commits into from

Conversation

EmileTrotignon
Copy link
Collaborator

There is no good reason to not preserve begin end by default.

If the user does not want them, he does not have to use them.

@EmileTrotignon EmileTrotignon requested a review from Julow June 6, 2025 17:01
Julow
Julow reviewed Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with the change :)

You need to update the manpages:

dune build @gen_manpage --auto-promote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmileTrotignon @Julow