Support the new functor type syntax MT -> MT#2755
Merged
Julow merged 4 commits intoocaml-ppx:mainfrom Nov 25, 2025
Merged
Conversation
Support the unnamed functor parameters in module types:
module type F = ARG -> S
The extended parser is changed to preserve the concrete syntax of
functor arguments in module types. Notably, these three lines are no
longer equivalent and the first two are no longer turned into the third:
module M : (_ : S) -> (_ : S) -> S = N
module M : S -> S -> S = N
module M : (_ : S) (_ : S) -> S = N
Restore the previous formatting.
Collaborator
Author
|
No regressions in test-branch, let's merge ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2646
Support the unnamed functor parameters in module types:
The extended parser is changed to preserve the concrete syntax of functor arguments in module types. Notably, these three lines are no longer equivalent and the first two are no longer turned into the third: