-
Notifications
You must be signed in to change notification settings - Fork 101
Support OCaml 5.5 #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OCaml 5.5 #606
Conversation
NathanReb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
We need to bump the upper bound in our dune-project/opam files to get a bit of feedback from the CI. We'll also need to update I'm happy include these extra steps in a separate PR. |
Signed-off-by: Patrick Ferris <[email protected]>
Fully support the 5.5 compiler as it is currently, with migrations. The new "external type" feature has not yet been encoded. This is deemed future work. Signed-off-by: Patrick Ferris <[email protected]>
a7360cc to
a226e73
Compare
|
Did you use our new |
NathanReb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Still curious to hear your feedback on the gencopy workflow to see if we can improve it somehow.
I guess one thing we could change is that it should probably dump a comment at the beginning of the file, hinting that it was initially generated with that tool and later modified. Having that comment point to the dev/README.md would help maintainers discover it if they're not aware of its existence.
|
Thanks for the review, @NathanReb ! I think this already might be out of date for some new changes in 5.5, but I'd rather get this is in and fix those up later in a separate PR. Re: gencopy -- yes! It was extremely useful. Some notes from me:
|
No description provided.