Conversation
|
We need to bump the upper bound in our dune-project/opam files to get a bit of feedback from the CI. We'll also need to update I'm happy include these extra steps in a separate PR. |
Signed-off-by: Patrick Ferris <patrick@sirref.org>
Fully support the 5.5 compiler as it is currently, with migrations. The new "external type" feature has not yet been encoded. This is deemed future work. Signed-off-by: Patrick Ferris <patrick@sirref.org>
a7360cc to
a226e73
Compare
|
Did you use our new |
NathanReb
left a comment
There was a problem hiding this comment.
Looks good to me! Still curious to hear your feedback on the gencopy workflow to see if we can improve it somehow.
I guess one thing we could change is that it should probably dump a comment at the beginning of the file, hinting that it was initially generated with that tool and later modified. Having that comment point to the dev/README.md would help maintainers discover it if they're not aware of its existence.
|
Thanks for the review, @NathanReb ! I think this already might be out of date for some new changes in 5.5, but I'd rather get this is in and fix those up later in a separate PR. Re: gencopy -- yes! It was extremely useful. Some notes from me:
|
No description provided.