Skip to content

Conversation

@patricoferris
Copy link
Collaborator

No description provided.

@patricoferris patricoferris added the no changelog Use this label to disable the changelog check github action label Oct 21, 2025
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NathanReb
Copy link
Collaborator

We need to bump the upper bound in our dune-project/opam files to get a bit of feedback from the CI.

We'll also need to update ast/supported_version/supported_version.ml, astlib/config/gen.ml and to add identity migrations and the relevant ast_505.ml.

I'm happy include these extra steps in a separate PR.

Signed-off-by: Patrick Ferris <[email protected]>
Fully support the 5.5 compiler as it is currently, with migrations. The
new "external type" feature has not yet been encoded. This is deemed
future work.

Signed-off-by: Patrick Ferris <[email protected]>
@patricoferris patricoferris changed the title Bump trunk CI build to 5.5.0 Support OCaml 5.5 Nov 25, 2025
@patricoferris patricoferris removed the no changelog Use this label to disable the changelog check github action label Nov 25, 2025
@NathanReb
Copy link
Collaborator

Did you use our new gencopy to generate the migrations? how did it work out?

Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Still curious to hear your feedback on the gencopy workflow to see if we can improve it somehow.

I guess one thing we could change is that it should probably dump a comment at the beginning of the file, hinting that it was initially generated with that tool and later modified. Having that comment point to the dev/README.md would help maintainers discover it if they're not aware of its existence.

@patricoferris
Copy link
Collaborator Author

Thanks for the review, @NathanReb ! I think this already might be out of date for some new changes in 5.5, but I'd rather get this is in and fix those up later in a separate PR.

Re: gencopy -- yes! It was extremely useful. Some notes from me:

  • It can be a bit awkward to actually use the tool itself because you start by switching to a compiler that is not supported so you cannot build gencopy itself. Of course, you can switch back to an earlier compiler, so perhaps just some clear documentation on that part.
  • The changes from 5.4 to 5.5 included updated names for record fields, this sounds like something gencopy might be able to deal with? It seemed to choose one name or the other consistently for the migrations which meant one was always wrong. In practice though, this is a simple enough post-edit to the files.
  • We now also have two constants -- one in Asttypes and the other in the AST itself, however the generate identical names. I think the Asttypes one does not actually need to be generated so I just deleted it.

@patricoferris patricoferris merged commit 7a89a69 into ocaml-ppx:main Dec 4, 2025
5 of 9 checks passed
@patricoferris patricoferris deleted the ci-trunk branch December 4, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants