Jsoo shapes #10767
Merged
Jsoo shapes #10767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
hhugo
force-pushed
the
jsoo-shape2
branch
2 times, most recently
from
c6cd81e to
aa79af2
Compare
hhugo
force-pushed
the
jsoo-shape2
branch
3 times, most recently
from
4ce62d0 to
7548f3d
Compare
Collaborator
Author
|
@vouillon, can you take a look ? |
rgrinberg
approved these changes
Jun 14, 2025
Member
|
@hhugo As far as I understand the code, we are only reading shapes from |
Collaborator
Author
I've just pushed the fix. |
Collaborator
Author
|
@vouillon, can you review this again ? I've addressed your comments. |
Collaborator
Author
|
ping @vouillon |
vouillon
approved these changes
Jul 7, 2025
Collaborator
Author
|
@rgrinberg, this is ready |
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
Sudha247
pushed a commit
to Sudha247/dune
that referenced
this pull request
Jul 23, 2025
* Add support for jsoo shapes Signed-off-by: Hugo Heuzard <[email protected]> * read shapes for cmo.js Signed-off-by: Hugo Heuzard <[email protected]> * accept diff Signed-off-by: Hugo Heuzard <[email protected]> --------- Signed-off-by: Hugo Heuzard <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Sep 3, 2025
CHANGES: ### Fixed - Fix jsoo separate compilation with modules_without_implementation. Regression introduced in ocaml/dune#10767. (ocaml/dune#12320, fixes ocaml/dune#12306 @hhugo) - Fix `runtest-js` mistakenly using wrong dependencies (ocaml/dune#12324, @vouillon) - Remove empty `.cram.test.t` directory during the running of a cram test. (ocaml/dune#12329, fixes ocaml/dune#12321, @Alizter) - Fix Cygwin bootstrap (ocaml/dune#12325, fixes ocaml/dune#12316, @Alizter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding PR ocsigen/js_of_ocaml#1594
The next release of Js_of_ocaml will be able to do some cross-module/cross-library optimization. Dune needs to be explicit about additional dependencies.