cram: locations for timeouts #12657
Draft
cram: locations for timeouts #12657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
changed the title
Alizter
force-pushed
the
push-mpprqltvlztr
branch
3 times, most recently
from
af6e1f5 to
591487b
Compare
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
push-mpprqltvlztr
branch
from
591487b to
52866d2
Compare
Alizter
changed the title
Collaborator
Author
|
Actually not so happy with this on second thoughts. Will think it over a bit. |
Member
|
In this case, the location is less important than producing the partial output that will hopefully help the user debug their test. |
Collaborator
Author
|
I think the location is important since it gives the editor diagnostic information. I'm experimenting with introducing both the error and the partial diff for both timeout and exit errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add locations for timed out commands.