Crashes on invalid config files #12659
Closed
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shon Feder <[email protected]>
shonfeder
force-pushed
the
shonfeder/invalid-config
branch
from
a480b4b to
b805c46
Compare
shonfeder
changed the title
Alizter
reviewed
Nov 3, 2025
| @@ -0,0 +1,3 @@ | |||
| $ export XDG_CONFIG_HOME=$PWD | |||
| $ '(cache enabled)' > config | |||
| $ dune --version | |||
Collaborator
There was a problem hiding this comment.
This won't read any config AFAIK as cmdliner short circuits this path. If you did something like dune build, that would fail saying the config doesn't have a dune lang version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to set up a repro for behavior I encountered on my machine with an invalid config in the default location, but I haven't been able to capture it in the cram test yet.