Skip to content

fix(rpc): handle EINVAL on macOS #12665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(rpc): handle EINVAL on macOS #12665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/csexp_rpc/csexp_rpc_stubs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#if defined(__APPLE__)

#include <errno.h>
#include <fcntl.h>
#include <sys/socket.h>
#include <sys/syscall.h>
Expand Down Expand Up @@ -44,7 +45,12 @@ CAMLprim value dune_set_nosigpipe(value v_socket) {
int socket = Int_val(v_socket);
int opt = 1;
int ret = setsockopt(socket, SOL_SOCKET, SO_NOSIGPIPE, &opt, sizeof(int));
if (ret < 0) {
if (ret < 0 && errno != EINVAL) {
// EINVAL can occur due to a race condition where the peer disconnects
// between accept() and setsockopt(). We can safely ignore it which seems to
// be the standard way of dealing with this issue on macOS/BSD. See issue
// https://github.com/ocaml/dune/issues/12660 for an example of this coming
// up in practice.
uerror("setsockopt", Nothing);
}
CAMLreturn(Val_unit);
Expand Down
Loading