refactor: Rename pinning functions to make their meaning clearer #13178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <marek@tarides.com>
| eval_url package.url | ||
| >>= (function | ||
| | None -> opam_package stack package | ||
| | None -> pinned_via_opam stack package |
Collaborator
Author
There was a problem hiding this comment.
@rgrinberg What I don't understand here is why this is calling the opam code path despite package.origin stating Dune?
Member
There was a problem hiding this comment.
The suggestion here should clarify it #13176 (comment)
Because what is Opam | Dune here is not the type of package but the type of pin that we have. And we can pin both types of packages with both types of pins.
Member
There was a problem hiding this comment.
To be more precise:
-
a dune package may have both opam pins and pin stanzas
-
an opam package may only have opam pins
-
A pin stanza may refer to a dune or an opam package
-
An opam file pin may refer to a dune or an opam package as well
rgrinberg
approved these changes
Jan 2, 2026
Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #13176.