Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion otherlibs/stdune/src/filename.ml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ module Extension = struct
let cmsi = ".cmsi"
let odoc = ".odoc"
let d = ".d"
let all_deps = ".all-deps"
let js = ".js"
let h = ".h"
let mlg = ".mlg"
Expand Down
1 change: 0 additions & 1 deletion otherlibs/stdune/src/filename.mli
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ module Extension : sig
val odoc : t
val h : t
val d : t
val all_deps : t
val js : t
val mlg : t
val json : t
Expand Down
12 changes: 2 additions & 10 deletions src/dune_graph/graph.ml
Original file line number Diff line number Diff line change
Expand Up @@ -220,17 +220,9 @@ module String_opt_map = Map.Make (struct

let serialize_summary t oc =
let open Aggregated in
(* CR-someday cmoseley: A memo node is created for each *.all-deps target
which fills up the summary with noise. This is a hacky fix for it right
now, it would be better to find something else to aggregate on or to move
these nodes to a single table since they only have a single entry each *)
let rename_all_deps label =
Option.map label ~f:(fun label ->
if String.ends_with ~suffix:".all-deps" label then "*.all-deps" else label)
in
let by_label =
Int.Map.fold t.nodes ~init:String_opt_map.empty ~f:(fun node acc ->
let label = rename_all_deps node.label in
let label = node.label in
let attributes =
Option.value
~default:Int.Map.empty
Expand All @@ -253,7 +245,7 @@ let serialize_summary t oc =
let by_label =
Edge.Set.fold t.edges ~init:by_label ~f:(fun edge acc ->
let get_label id =
Option.bind (Int.Map.find t.nodes id) ~f:(fun node -> rename_all_deps node.label)
Option.bind (Int.Map.find t.nodes id) ~f:(fun node -> node.label)
in
let src_label = get_label edge.src_id in
let dst_label = get_label edge.dst_id in
Expand Down
Loading
Loading