Merged
Conversation
christinerose
approved these changes
Oct 5, 2023
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/branch/doc__improve_opam_file_doc
branch
from
e4412b6 to
ecd66ca
Compare
Collaborator
Author
|
@emillon I've now removed the synopsis change as discussed in the meeting. |
Alizter
removed
the
requires-team-discussion
christinerose
approved these changes
Oct 27, 2023
emillon
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure what makes dune "opinionated", but whatever it is, I don't think it is our main feature. I've therefore swapped "opinionated" for "composable" which seems like a better thing to advertise.I've also changed the wording in the synopsis of the opam file, including "composable" there too so that readers know what we mean.
cc @emillon @christinerose
Edit: I've undone the "opinionated -> composable" change.