Decouple no-dune.t test from dune internal paths - #2078
Merged
voodoos merged 2 commits intoJun 13, 2026
Conversation
Dune doesn't provide the layout of its install directories as part of its public API. These internals are changing in dune 3.24, so this path will change. Using `dune describe location` uses dunes stable API to find the path for the needed binaries.
shonfeder
commented
Jun 12, 2026
Comment on lines
-2
to
-3
| $ cp ../../../../install/default/bin/ocamlmerlin bin/ocamlmerlin | ||
| $ cp ../../../../install/default/bin/ocamlmerlin-server bin/ocamlmerlin-server |
Member
Author
There was a problem hiding this comment.
dune describe location outputs to stderr (for no good reason I can think of). This should be fixed at some point, but this will continue to work when when it is.
This was referenced Jun 12, 2026
Merged
Alizter
reviewed
Jun 12, 2026
voodoos
approved these changes
Jun 13, 2026
voodoos
left a comment
voodoos
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot @shonfeder and @Alizter !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dune doesn't provide the layout of its install directories as part of its public API. These internals are changing in dune 3.24, as a result of ocaml/dune#14432, so this path will change. Using
dune describe locationuses dunes stable API to find the path for the needed binaries.The need for this update was identified in the revdeps tests on the pre-releas for dune 3.24 in ocaml/opam-repository#29996 (comment) .
Thanks to @Alizter for diagnosing the affect of the breaking change here.