WIP: Fix type-annotate action for functions #1048
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Rafal
force-pushed
the
fix-type-annotate-for-functions
branch
from
439f004 to
e50147f
Compare
rgrinberg
reviewed
Mar 13, 2023
| let+ original_text = get_source_text doc loc in | ||
| let arrow = " -> " in | ||
| let typ' = | ||
| Str.split (Str.regexp arrow) typ |
There was a problem hiding this comment.
Str isn't thread safe so we avoid it. Try using Re.split or something similar.
There was a problem hiding this comment.
It's also not ideal that we need to deal with strings here at all btw. Shouldn't it be possible to use the type tree representation to drop the args instead?
There was a problem hiding this comment.
Hey Rudi, it's just a draft and work in progress. I have opened a PR so that it's visible that I'm working on this feature.
Thanks for your suggestions (will keep them in mind), but I'm not sure if it's worth it to do review now. 🙂
There was a problem hiding this comment.
Sure thing. Some people like the feedback early, others prefer it all at the end. I can go either way
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #801