Vendoring Omd 1.3.2 #1118
Closed
Vendoring Omd 1.3.2 #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the dependency on omd.1.3.2 and add the corresponding sources, without tests. Requiring to have omd strictly before 2.0.0~alpha1 is a foot gun for newbies. ocaml-lsp-server is among the first package newbies have to install. In that process, old omd 1.3.2 gets installed. Later, when starting to code with Omd, they either don't understand why their installed API doesn't match the publicly documented one or start coding with an obsolete API.
|
Seems like we're moving away from omd here: #1088 Otherwise, I agree with your assessment. |
|
Sorry for the noise. I hadn't noticed @tmattio PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on omd and adds the corresponding
sources without tests.
Requiring to have omd strictly before 2.0.0~alpha1 is a foot gun
for newbies. ocaml-lsp-server is among the first packages newbies
have to install. In that process, old omd 1.3.2 gets installed.
Later, when starting to code with Omd, they either don't understand
why their installed API doesn't match the publicly documented one
or start coding with an obsolete API.