Open
Conversation
Contributor
Author
|
requires |
xvw
reviewed
Jan 31, 2025
Collaborator
|
Does it change the behaviour of the custom request? |
Contributor
Author
No it doesn't. The output should be the same. |
xvw
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances jump functionality used in :
Instead of recursively checking if each target is possible, we now send a single query and get all the possible jump targets.
The trace on computing code actions is:
Getting each target separately
[Trace - 5:07:56 AM] Received response 'textDocument/codeAction - (2)' in 523ms.[Trace - 5:08:35 AM] Received response 'textDocument/codeAction - (17)' in 18ms.Getting all targets at once
[Trace - 5:15:50 AM] Received response 'textDocument/codeAction - (2)' in 244ms.Trace - 5:15:59 AM] Received response 'textDocument/codeAction - (11)' in 7ms.which indicates some performance improvement.
This Pr is dependent on the corresponding Merlin implementation ocaml/merlin#1891
cc @voodoos