[minor] Lexer.update_loc: use labeled arguments for readability#14670
Open
gasche wants to merge 1 commit intoocaml:trunkfrom
Open
[minor] Lexer.update_loc: use labeled arguments for readability#14670gasche wants to merge 1 commit intoocaml:trunkfrom
gasche wants to merge 1 commit intoocaml:trunkfrom
Conversation
gasche
force-pushed
the
minor_update_loc
branch
from
9b6d75f to
15306bc
Compare
redianthus
approved these changes
Mar 24, 2026
Member
redianthus
left a comment
redianthus
left a comment
There was a problem hiding this comment.
It is obviously correct and much more readable.
gasche
force-pushed
the
minor_update_loc
branch
from
15306bc to
762cf95
Compare
MisterDA
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.