Skip to content

Conversation

@raphael-proust
Copy link
Contributor

addressing #24423 (comment)

@raphael-proust
Copy link
Contributor Author

@sim642 The patch seems to work: gcc is correctly found on macos. There are now different errors.

  • Is it ok to merge with these errors? (Do you want to mark the package a unavailable on some platforms because the errors indicate that the software is not correct there? Do you think those errors are ok?)
  • If you want to copy the error logs you should do so before the PR is merged.

@sim642
Copy link
Contributor

sim642 commented Sep 22, 2023

I've copied the logs into upstream issues to look into. I think oraclelinux-9 and freebsd are both new for opam CI, so there might be something up with that because all the tests fail.

@mseri
Copy link
Member

mseri commented Sep 22, 2023

oraclelinux should disappear soon, only freebsd is here to stay :)

@mseri
Copy link
Member

mseri commented Sep 26, 2023

Thanks

@mseri mseri merged commit 316bd0c into master Sep 26, 2023
@mseri mseri deleted the goblint-cil-patch branch September 26, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants