Skip to content

Conversation

raphael-proust
Copy link
Contributor

This pull-request concerns:

  • lwt.6.0.0~alpha01: Promises and event-driven I/O
  • lwt_direct.6.0.0~alpha01: Direct-style control-flow and await for Lwt


🐫 Pull-request generated by opam-publish v2.5.1

@raphael-proust
Copy link
Contributor Author

It seems to break lwt_log, which has been deprecated for a while anyway so maybe that's ok, I'll add a constraint

The (long deprecated) Lwt_main.exit_hooks have been removed in lwt.6.
@raphael-proust
Copy link
Contributor Author

I might have also broken some js uses, need to check if i broke all of them or just some

e.g.,

- (cd _build/default/test/js && /home/opam/.opam/4.14/bin/js_of_ocaml --no-source-map -o main.bc.js /home/opam/.opam/4.14/lib/cstruct/cstruct.js main.bc-for-jsoo)
- Warning [missing-primitive]: There are some missing primitives.
- Dummy implementations (raising 'Failure' exception) will be used if they are not available at runtime.
- You can prevent the generation of dummy implementations with the commandline option '--disable genprim'
- Missing primitives:
-   caml_mutex_lock
-   caml_mutex_new
-   caml_mutex_unlock
-   caml_thread_id
-   caml_thread_initialize
-   caml_thread_self
- File "test/js/dune", lines 3-7, characters 0-90:
- 3 | (rule
- 4 |  (alias runtest)
- 5 |  (package tezt)
- 6 |  (deps main.bc.js)
- 7 |  (action (run node main.bc.js)))
- (cd _build/default/test/js && /usr/bin/node main.bc.js)
- Fatal error: exception Failure("caml_thread_initialize not implemented")
[ERROR] The compilation of tezt.4.0.0 failed at "dune runtest -p tezt -j 71".

@raphael-proust
Copy link
Contributor Author

A few packages broken by the removal of Lwt_main.*hooks (same that breaks lwt_log). These have been deprecated for a while with an alternative available for a while. So I don't think it's a blocker for an alpha release, but i'll need to ping all the affected packages.

@mseri
Copy link
Member

mseri commented Jul 24, 2025

Could you send a PR with the necessary upper bounds?

because `~` has a specific meaning in version comparison it turns out
that `< "6"` includes `6…~…`
@@ -14,7 +14,7 @@ depends: [
"ocaml" {>= "4.11"}
"base-unix"
"curl" {= version}
"lwt"
"lwt" {<= "5.999"}
Copy link
Member

@mseri mseri Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"lwt" {<= "5.999"}
"lwt" {<= "6~"}

This would prevent it and not force a 5 bound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants