Skip to content

[new release] melange-jest (0.2.0)#29029

Merged
jmid merged 2 commits intoocaml:masterfrom
anmonteiro:release-melange-jest-0.2.0
Dec 13, 2025
Merged

[new release] melange-jest (0.2.0)#29029
jmid merged 2 commits intoocaml:masterfrom
anmonteiro:release-melange-jest-0.2.0

Conversation

@anmonteiro
Copy link
Contributor

CHANGES:

- port `@mel.send.pipe` to `@mel.send` + `@mel.this` by @anmonteiro (melange-community/melange-jest#18)
Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I see CI failing runtest across the board, e.g.,
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/dc256e36cd2114951fe07f4321c2b26e4bb14d33/variant/compilers,4.14,melange-jest.0.2.0,tests

#=== ERROR while compiling melange-jest.0.2.0 =================================#
# context              2.5.0 | linux/x86_64 | ocaml-base-compiler.4.14.2 | pinned(https://github.com/melange-community/melange-jest/releases/download/0.2.0/melange-jest-0.2.0.tbz)
# path                 ~/.opam/4.14/.opam-switch/build/melange-jest.0.2.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p melange-jest -j 71 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/melange-jest-7-476a47.env
# output-file          ~/.opam/log/melange-jest-7-476a47.out
### output ###
# File "dune", line 12, characters 7-10:
# 12 |   (run npx jest)))
#             ^^^
# Error: Program npx not found in the tree or in PATH
#  (context: default)

Is this missing a conf-npm {with-test} dependency? 🤔

Removed the '@runtest' job from the opam file.
@anmonteiro
Copy link
Contributor Author

Thank you, I forgot to remove the @runtest alias.

Is this missing a conf-npm {with-test} dependency? 🤔

I'd rather remove the @runtest alias, since we test this in CI and external deps are harder than they should.

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks - CI LGTM now 👍

Would you consider adding an x-maintenance-intent entry?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md

@anmonteiro
Copy link
Contributor Author

Would you consider adding an x-maintenance-intent entry?

Yes, I will add these upstream.

@jmid
Copy link
Member

jmid commented Dec 13, 2025

OK, thanks!

@jmid jmid removed the question label Dec 13, 2025
@jmid jmid merged commit 014c6a6 into ocaml:master Dec 13, 2025
3 of 4 checks passed
@anmonteiro anmonteiro deleted the release-melange-jest-0.2.0 branch December 13, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants