fix cca packages #29155
Merged
fix cca packages #29155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdliner error:
File "git_diffast.ml", line 379, characters 8-17:
379 | args#repo $ sha1s)
^^^^^^^^^
Error: This expression has type string Cmdliner.Term.t
but an expression was expected of type Fpath.t Cmdliner.Term.t
Type string is not compatible with type Fpath.t
make: *** [../../rules.mk:105: git_diffast.cmx] Error 2
raphael-proust
force-pushed
the
fix-cca-builds
branch
from
ac52def to
014b8d7
Compare
Member
|
Love it! ❤️ There's also an issue for this: #27952 |
Contributor
Author
0.6.2The build now passes but it hits an error at installation: same error happens on other versions of the package. i'd say let's merge the 6.2 changes anyway, it's better than before 0.7now the package is unavailable, i'm guessing there are incompatible version constraints?? i'm pushing a commit to relax the constraint |
Contributor
Author
|
ok now both fail at install rather than compile, i think that's better (shorter error message, further along in the process) if someone (@codinuum ?) wants to address the installation errors we can use this PR as a base, otherwise i'd say let's merge this |
Member
|
Let's merge in the meantime! thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they are causing CI errors in #29147