Skip to content

Conversation

@stopusingghpls
Copy link
Contributor

fix project setup

"@doc" {with-doc}
]
]
dev-repo: "git+https://codeberg.org/removewingman/restricted.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

available: os = "openbsd" | os = "linux"
dev-repo: "git+https://codeberg.org/removewingman/restricted.git"

I would make this available on openbsd and linux, or pledge to check the resources is also available on other systems?

Copy link
Contributor Author

@stopusingghpls stopusingghpls Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the dune fix.
I don't know what you mean by:

or pledge to check the resources is also available on other systems?

The idea is to give people the option to specify which privileges there program will need, the actual restriction will be implemented from time to time, it cross platform, since the c call will not be called on e.g. windows:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what I meant is that as you say and as you do in https://codeberg.org/removewingman/restricted/src/branch/main/lib/restricted.ml#L107, only on openbsd the restricion are applied. I thought on other platform it was not possilbe to check if the privileges were respected or not, perhaps with the exception of linux where you can use the linked pledge.

In that sense I was wondering if it was better to make it available only on the platform where the library is actually doing something. But I understand in the meantime you write the permission requirements and then, if at some point it can be implemented on your platform, you can make it check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it fine like that or do you still want it changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all right as is. I thought I had merged yesterday already, sorry

@mseri mseri merged commit b08a830 into ocaml:master Jan 8, 2026
4 of 5 checks passed
@mseri
Copy link
Member

mseri commented Jan 8, 2026

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants