-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Package restricted-1.1 #29182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package restricted-1.1 #29182
Conversation
| "@doc" {with-doc} | ||
| ] | ||
| ] | ||
| dev-repo: "git+https://codeberg.org/removewingman/restricted.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
available: os = "openbsd" | os = "linux"
dev-repo: "git+https://codeberg.org/removewingman/restricted.git"
I would make this available on openbsd and linux, or pledge to check the resources is also available on other systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the dune fix.
I don't know what you mean by:
or pledge to check the resources is also available on other systems?
The idea is to give people the option to specify which privileges there program will need, the actual restriction will be implemented from time to time, it cross platform, since the c call will not be called on e.g. windows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what I meant is that as you say and as you do in https://codeberg.org/removewingman/restricted/src/branch/main/lib/restricted.ml#L107, only on openbsd the restricion are applied. I thought on other platform it was not possilbe to check if the privileges were respected or not, perhaps with the exception of linux where you can use the linked pledge.
In that sense I was wondering if it was better to make it available only on the platform where the library is actually doing something. But I understand in the meantime you write the permission requirements and then, if at some point it can be implemented on your platform, you can make it check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is it fine like that or do you still want it changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is all right as is. I thought I had merged yesterday already, sorry
|
Thanks |
fix project setup