Skip to content

Comments

conf-zlib: update for ortools_solvers#29394

Open
tbrk wants to merge 1 commit intoocaml:masterfrom
tbrk:conf-zlib-patch
Open

conf-zlib: update for ortools_solvers#29394
tbrk wants to merge 1 commit intoocaml:masterfrom
tbrk:conf-zlib-patch

Conversation

@tbrk
Copy link
Contributor

@tbrk tbrk commented Feb 15, 2026

Changes allowing conf-zlib to be used as a dependency for ortools_solvers.

for centos < 10: include zlib-static
for centos >= 10: use zlib-ng-compat-devel
add msys2
add suse and opensuse
add freebsd

Changes allowing conf-zlib to be used as a dependency for ortools_solvers.

for centos < 10: include zlib-static
for centos >= 10: use zlib-ng-compat-devel
add msys2
add suse and opensuse
add freebsd
Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Improvements to conf-zlib are most welcome! 🙏

I can see conf-zlib.1/opam has been improved over the past 10 years.
Rather than roll a version 2 (which opens up for, e.g., unwanted lower-bound conf-zlib search) I propose adding these changes to the original file.

The MSys2 changes are not quite right.

We offer 2 options to build standalone Windows executables:

  • MinGW distributed through Cygwin
  • MinGW distributed through MSys2

This however requires installing the packages prefixed with mingw,
as the regular Cygwin/MSys2 packages will introduce a dependency on their runtimes (cygwin1.dll and similar for MSys2). This means using

For more background on MinGW conf-packaging see

  • the template PR #26072
  • the fix PR correcting a subtle side condition typo #28939

@jmid
Copy link
Member

jmid commented Feb 19, 2026

Looking some more, MinGW support for zlib was already added in e776c77 and had its side-condition fixed in 0b29baf. With that in mind, I don't understand what these MSys2 changes are supposed to fix... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants