[new release] tm-grammars and co (1.0.0)#29474
Open
davesnx wants to merge 1 commit intoocaml:masterfrom
Open
Conversation
davesnx
changed the title
Contributor
Author
|
Updated the title to not break the github ui T_T |
davesnx
force-pushed
the
release-tm-grammars-1.0.0
branch
from
5e15b79 to
528612e
Compare
Member
|
This is a useful package to have, but seems like a lot of unnecessary opam packages where one would do. Have you considered making this a single tm-grammars package, with findlib submodules for each language (tm-grammars.ocaml). That would let you publish it simply, put less pressure on the opam solver, let you have one maintenance-intent, and still keep the dependency cone simple for downstream users. |
CHANGES: - Published OCaml package that exposes TextMate grammars as JSON strings. - Each language is a findlib sublibrary (e.g. `tm-grammars.ocaml`, `tm-grammars.tsx`). - Downstream users depend on `tm-grammars` and add only the sublibraries they need to `(libraries ...)`. - Generated package setup driven by `sources.json`.
davesnx
force-pushed
the
release-tm-grammars-1.0.0
branch
from
528612e to
71a64b9
Compare
Contributor
Author
|
That's a much better package design, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All bundled TextMate grammars
CHANGES:
tm-grammar-<language>packages for the supported language IDs.tm-grammars, a bundled package with direct accessors for all included grammars.sources.json.