[new release] ciao_lwt (3 packages) (0.1)#29477
Open
Julow wants to merge 3 commits intoocaml:masterfrom
Open
Conversation
CHANGES: Initial release
Contributor
Author
|
The CI tries to build with |
mseri
reviewed
Feb 27, 2026
mseri
reviewed
Feb 27, 2026
mseri
reviewed
Feb 27, 2026
| depends: [ | ||
| "dune" {>= "3.17"} | ||
| "ocaml" {= "5.2"} | ||
| "cmdliner" |
Contributor
Author
There was a problem hiding this comment.
It is used needed by the vendored ocamlformat.
Member
There was a problem hiding this comment.
Yes but it is declared already on line 25, if you keep both it will resolve to no bounds
mseri
reviewed
Feb 27, 2026
| "dune" {>= "3.17"} | ||
| "ocaml" {>= "4.08"} | ||
| "base" {>= "v0.12.0"} | ||
| "cmdliner" {>= "1.1.0"} |
Member
There was a problem hiding this comment.
Should this also be smaller than 2?
mseri
reviewed
Feb 27, 2026
| depends: [ | ||
| "dune" {>= "3.17"} | ||
| "ocaml" | ||
| "cmdliner" |
Member
There was a problem hiding this comment.
Like above, it is declared also below with partial bounds
mseri
reviewed
Feb 27, 2026
| "cmdliner" | ||
| "ocaml" {>= "4.08"} | ||
| "base" {>= "v0.12.0"} | ||
| "cmdliner" {>= "1.1.0"} |
Member
There was a problem hiding this comment.
Should this also be smaller than 2?
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tool for migrating from Lwt to direct-style concurrency libraries
CHANGES:
Initial release