disable tests for ppx_minidebug.2.{3,4}.0 by shonfeder · Pull Request #30183 · ocaml/opam-repository

shonfeder · 2026-07-02T19:18:11Z

There is reason to believe these are failing due to brittle text fixtures, creating noise in revdeps runs for other packages.

See the discussion in #30157 (comment) and preceding.

The CI results in the initial commit c6c567d show that the tests for these package versions fail due to unsatisfied expectations in the test expectations, such as

#=== ERROR while compiling ppx_minidebug.2.4.0 ================================#
# context              2.5.1 | linux/x86_64 | ocaml-base-compiler.5.4.1 | pinned(https://github.com/lukstafi/ppx_minidebug/archive/refs/tags/2.4.0.6.tar.gz)
# path                 ~/.opam/5.4/.opam-switch/build/ppx_minidebug.2.4.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppx_minidebug -j 71 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/ppx_minidebug-7-7a4b62.env
# output-file          ~/.opam/log/ppx_minidebug-7-7a4b62.out
### output ###
# File "test/test_debug_log_nothing.expected.ml", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/test_debug_log_nothing.expected.ml _build/default/test/test_debug_log_nothing.actual.ml
# diff --git a/_build/default/test/test_debug_log_nothing.expected.ml b/_build/default/test/test_debug_log_nothing.actual.ml
# index 6c38ebb..69024dd 100644
# --- a/_build/default/test/test_debug_log_nothing.expected.ml
# +++ b/_build/default/test/test_debug_log_nothing.actual.ml
# @@ -2,10 +2,10 @@ module Debug_runtime = (val
#    Minidebug_runtime.debug_flushing ~filename:"debugger_show_log_nothing" ())
#  ;;()
#  let rec loop_exceeded (x : int) =
# -  (let z = (); (x - 1) / 2 in
# +  (let z : int = (); (x - 1) / 2 in
#     if x <= 0 then 0 else z + (loop_exceeded (z + (x / 2))) : int)
#  let () =
#    try print_endline @@ (Int.to_string @@ (loop_exceeded 17))
#    with | _ -> print_endline "Raised exception."
# -let bar () = (for i = 0 to 100 do let _baz = i * 2 in () done : unit)
# +let bar () = (for i = 0 to 100 do let _baz : int = i * 2 in () done : unit)
#  let () = try bar () with | _ -> print_endline "Raised exception."
# File "test/test_debug_pp.expected.ml", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/test_debug_pp.expected.ml _build/default/test/test_debug_pp.actual.ml
# diff --git a/_build/default/test/test_debug_pp.expected.ml b/_build/default/test/test_debug_pp.actual.ml
# index 315c5bb..dd128a7 100644
# --- a/_build/default/test/test_debug_pp.expected.ml
# +++ b/_build/default/test/test_debug_pp.actual.ml
# @@ -13,7 +13,7 @@ let bar (x : t) =
#          ~entry_id:__entry_id ~log_level:1 `Debug;
#        Debug_runtime.log_value_pp ?descr:(Some "x") ~entry_id:__entry_id
#          ~log_level:1 ~pp ~is_result:false (lazy x));
# -     (match let y =
# +     (match let y : num =
#                let __entry_id = Debug_runtime.get_entry_id () in
#                ();
#                Debug_runtime.open_log ~fname:"test_debug_pp.ml" ~start_lnum:8
# @@ -55,7 +55,7 @@ let baz (x : t) =
#          ~entry_id:__entry_id ~log_level:1 `Debug;
#        Debug_runtime.log_value_pp ?descr:(Some "x") ~entry_id:__entry_id
#          ~log_level:1 ~pp ~is_result:false (lazy x));
# -     (match let { first = y; second = z } as _yz =
# +     (match let ({ first = y; second = z } as _yz) : t =
#                let __entry_id = Debug_runtime.get_entry_id () in
#                ();
#                Debug_runtime.open_log ~fname:"test_debug_pp.ml" ~start_lnum:14
# @@ -107,7 +107,7 @@ let rec loop (depth : num) (x : t) =
#                  loop (depth + 1)
#                    { first = (x.second + 1); second = (x.first / 2) }
#                else
# -                (let y =
# +                (let y : num =
#                     let __entry_id = Debug_runtime.get_entry_id () in
#                     ();
#                     Debug_runtime.open_log ~fname:"test_debug_pp.ml"
# @@ -130,7 +130,7 @@ let rec loop (depth : num) (x : t) =
#                          (Debug_runtime.close_log ~fname:"test_debug_pp.ml"
#                             ~start_lnum:23 ~entry_id:__entry_id;
#                           raise e)) in
# -                 let z =
# +                 let z : num =
#                     let __entry_id = Debug_runtime.get_entry_id () in
#                     ();
#                     Debug_runtime.open_log ~fname:"test_debug_pp.ml"
# File "test/test_debug_log_level_consistency.expected.ml", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/test_debug_log_level_consistency.expected.ml _build/default/test/test_debug_log_level_consistency.actual.ml
# diff --git a/_build/default/test/test_debug_log_level_consistency.expected.ml b/_build/default/test/test_debug_log_level_consistency.actual.ml
# index d984a8e..8ec8f16 100644
# --- a/_build/default/test/test_debug_log_level_consistency.expected.ml
# +++ b/_build/default/test/test_debug_log_level_consistency.actual.ml
# @@ -23,7 +23,7 @@ let foo (x : int) =
#          ~message:"foo" ~entry_id:__entry_id ~log_level:1 `Debug;
#        Debug_runtime.log_value_show ?descr:(Some "x") ~entry_id:__entry_id
#          ~log_level:1 ~is_result:false (lazy (([%show : int]) x)));
# -     (match let y =
# +     (match let y : int =
#                let __entry_id = Debug_runtime.get_entry_id () in
#                ();
#                Debug_runtime.open_log
# File "test/test_debug_interrupts.expected.ml", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/test_debug_interrupts.expected.ml _build/default/test/test_debug_interrupts.actual.ml
# diff --git a/_build/default/test/test_debug_interrupts.expected.ml b/_build/default/test/test_debug_interrupts.actual.ml
# index 33f9d5c..4395698 100644
# --- a/_build/default/test/test_debug_interrupts.expected.ml
# +++ b/_build/default/test/test_debug_interrupts.actual.ml
# @@ -29,7 +29,7 @@ let rec loop_exceeded (x : int) =
#             ~start_lnum:8 ~entry_id:__entry_id;
#           failwith "ppx_minidebug: max_nesting_depth exceeded")
#        else
# -        (match let z =
# +        (match let z : int =
#                   let __entry_id = Debug_runtime.get_entry_id () in
#                   ();
#                   if Debug_runtime.exceeds_max_children ()
# @@ -141,7 +141,7 @@ let bar () =
#                                failwith
#                                  "ppx_minidebug: max_nesting_depth exceeded")
#                             else
# -                             (match let _baz =
# +                             (match let _baz : int =
#                                        let __entry_id =
#                                          Debug_runtime.get_entry_id () in
#                                        ();
# File "test/test_debug_sexp.expected.ml", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/test_debug_sexp.expected.ml _build/default/test/test_debug_sexp.actual.ml
# diff --git a/_build/default/test/test_debug_sexp.expected.ml b/_build/default/test/test_debug_sexp.actual.ml
# index 80c432f..bb4c0d5 100644
# --- a/_build/default/test/test_debug_sexp.expected.ml
# +++ b/_build/default/test/test_debug_sexp.actual.ml
# @@ -10,7 +10,7 @@ let foo (x : int) =
#        ~entry_id:__entry_id ~log_level:1 `Debug;
#      Debug_runtime.log_value_sexp ?descr:(Some "x") ~entry_id:__entry_id
#        ~log_level:1 ~is_result:false (lazy (([%sexp_of : int]) x)));
# -   (match let y =
# +   (match let y : int =
#              let __entry_id = Debug_runtime.get_entry_id () in
#              ();
#              Debug_runtime.open_log ~fname:"test_debug_sexp.ml" ~start_lnum:10
# @@ -54,7 +54,7 @@ let bar (x : t) =
#        ~entry_id:__entry_id ~log_level:1 `Debug;
#      Debug_runtime.log_value_sexp ?descr:(Some "x") ~entry_id:__entry_id
#        ~log_level:1 ~is_result:false (lazy (([%sexp_of : t]) x)));
# -   (match let y =
# +   (match let y : int =
#              let __entry_id = Debug_runtime.get_entry_id () in
#              ();
#              Debug_runtime.open_log ~fname:"test_debug_sexp.ml" ~start_lnum:18
# @@ -95,7 +95,7 @@ let baz (x : t) =
#        ~entry_id:__entry_id ~log_level:1 `Debug;
#      Debug_runtime.log_value_sexp ?descr:(Some "x") ~entry_id:__entry_id
#        ~log_level:1 ~is_result:false (lazy (([%sexp_of : t]) x)));
# -   (match let (y, z) as _yz =
# +   (match let ((y, z) as _yz) : (int * int) =
#              let __entry_id = Debug_runtime.get_entry_id () in
#              ();
#              Debug_runtime.open_log ~fname:"test_debug_sexp.ml" ~start_lnum:24
# @@ -114,7 +114,7 @@ let baz (x : t) =
#                   (Debug_runtime.close_log ~fname:"test_debug_sexp.ml"
#                      ~start_lnum:24 ~entry_id:__entry_id;
#                    raise e)) in
# -          let (u, w) as _uw =
# +          let ((u, w) as _uw) : (int * int) =
#              let __entry_id = Debug_runtime.get_entry_id () in
#              ();
#              Debug_runtime.open_log ~fname:"test_debug_sexp.ml" ~start_lnum:25

Maybe it's due to changes in the ppxlib or the compiler. In any case, this creates noise in revdeps tests, so the next commit disables the tests.

FYI @lukstafi

There is reason to believe these are failing due to brittle text fixtures, creating noise in revdeps runs for other packages.

These fail with unrelated errors such as the following: ``` --- a/_build/default/test/test_debug_log_nothing.expected.ml +++ b/_build/default/test/test_debug_log_nothing.actual.ml @@ -2,10 +2,10 @@ module Debug_runtime = (val Minidebug_runtime.debug_flushing ~filename:"debugger_show_log_nothing" ()) ;;() let rec loop_exceeded (x : int) = - (let z = (); (x - 1) / 2 in + (let z : int = (); (x - 1) / 2 in if x <= 0 then 0 else z + (loop_exceeded (z + (x / 2))) : int) let () = try print_endline @@ (Int.to_string @@ (loop_exceeded 17)) with | _ -> print_endline "Raised exception." -let bar () = (for i = 0 to 100 do let _baz = i * 2 in () done : unit) +let bar () = (for i = 0 to 100 do let _baz : int = i * 2 in () done : unit) let () = try bar () with | _ -> print_endline "Raised exception." ```

jmid

Thanks!

CI is just waiting for the dog-slow riscv64 jobs to complete - feel free to merge before!

shonfeder · 2026-07-02T22:22:41Z

Will do so! Thanks :)

check tests for ppx_minidebug.2.{3,4}.0

c6c567d

There is reason to believe these are failing due to brittle text fixtures, creating noise in revdeps runs for other packages.

shonfeder marked this pull request as draft July 2, 2026 19:18

shonfeder marked this pull request as ready for review July 2, 2026 19:29

shonfeder changed the title ~~check tests for ppx_minidebug.2.{3,4}.0~~ disable tests for ppx_minidebug.2.{3,4}.0 Jul 2, 2026

jmid approved these changes Jul 2, 2026

View reviewed changes

jmid added the consider for merge label Jul 2, 2026

shonfeder merged commit 969cade into ocaml:master Jul 2, 2026
4 of 5 checks passed

shonfeder deleted the ppx_minidebug-tests branch July 2, 2026 22:22

shonfeder mentioned this pull request Jul 3, 2026

[new release] ppx_deriving (6.1.2) #30167

Merged

Navigation Menu

Uh oh!

disable tests for ppx_minidebug.2.{3,4}.0 - #30183

disable tests for ppx_minidebug.2.{3,4}.0#30183
shonfeder merged 2 commits into
ocaml:masterfrom
shonfeder:ppx_minidebug-tests

shonfeder commented Jul 2, 2026 •

edited

Loading

Uh oh!

jmid left a comment

Uh oh!

shonfeder commented Jul 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shonfeder commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmid left a comment

Choose a reason for hiding this comment

Uh oh!

shonfeder commented Jul 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shonfeder commented Jul 2, 2026 •

edited

Loading