Skip to content

opam 2.4 #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smorimoto merged 3 commits into from
Jul 19, 2025
Merged

opam 2.4 #970

smorimoto merged 3 commits into from
Jul 19, 2025

Conversation

@smorimoto
Copy link
Member

@smorimoto smorimoto commented Apr 18, 2025

No description provided.

@smorimoto smorimoto added the enhancement New feature or request label Apr 18, 2025
@smorimoto smorimoto force-pushed the opam-2.4 branch 2 times, most recently from 8ec27ca to c979452 Compare April 19, 2025 12:21
kit-ty-kate
kit-ty-kate reviewed Apr 21, 2025
View reviewed changes
@smorimoto smorimoto force-pushed the opam-2.4 branch 2 times, most recently from b97be6b to f9b1f9a Compare May 11, 2025 21:39
@kit-ty-kate
Copy link
Member

kit-ty-kate commented May 19, 2025

Is this PR waiting for anything in particular from opam? It would be great to be able to test opam 2.4 in setup-ocaml

@smorimoto
Copy link
Member Author

smorimoto commented May 20, 2025

You can pull the opam 2.4 beta without waiting for this release. This was a change for the official release of opam 2.4.

@smorimoto smorimoto marked this pull request as ready for review July 18, 2025 09:49
@cknitt cknitt mentioned this pull request Jul 19, 2025
Merged
smorimoto added 3 commits July 20, 2025 04:19
@smorimoto
GNU patch and diff command are no longer runtime dependencies
2323d62 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Unlock opam 2.4
3e279d2 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Use latest runner images
b4bf062 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto merged commit f20f44b into master Jul 19, 2025
18 checks passed
@smorimoto smorimoto deleted the opam-2.4 branch July 19, 2025 19:28
@davesnx
Copy link

davesnx commented Jul 22, 2025

I discovered an issue by having setup-ocaml@3 breaking my instalation since one package depends on opam, and I wondered if those opam updates should be major versions in setup-ocaml?

@smorimoto
Copy link
Member Author

smorimoto commented Jul 22, 2025

Can you explain the issue more specifically? This should not break anything as long as you use the workflow we recommend.

@davesnx
Copy link

davesnx commented Jul 22, 2025

  • in our ci we used setup-ocaml@3 in reason-react
  • reason-react depends on opam-check-npm-deps https://github.com/ahrefs/opam-check-npm-deps
  • at the time of the error reported below, we depend on opam-check-npm-deps.3.0.1 which is available only opam-version >= "2.3" & opam-version < "2.4"

https://github.com/reasonml/reason-react/actions/runs/16439383014/job/46456359814

Running the CI after setup-ocaml@3.4.0 was released broke the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smorimoto @kit-ty-kate @davesnx