[crop] Add disable_window_dragging option, enable by default#62
Open
po5 wants to merge 1 commit intooccivink:masterfrom
Open
[crop] Add disable_window_dragging option, enable by default#62po5 wants to merge 1 commit intooccivink:masterfrom
po5 wants to merge 1 commit intooccivink:masterfrom
Conversation
Owner
|
Sounds good, but I would like it to check the state of the property on down event, and only re-enable it if it was actually enabled. |
Author
|
True, will do that. |
dexeonify
pushed a commit
to dexeonify/mpv-config
that referenced
this pull request
Sep 14, 2025
Second take of 0f2ea30 because I noticed Sneakpeakcss didn't fully implement click-and-drag crop selection exactly as in the original PR. Previously, you had to click the first point before you can hold and drag to crop. This commit integrates po5's complex keybinds changes, allowing you to start, select and submit the crop in a single hold-and-drag operation! One of the roadblock to patching po5's PR directly was the condition `or (crop_first_corner.x == corner_video.x and crop_first_corner.y == corner_video.y)`. It was causing errors due to a missing `corner_video` variable, which was removed in occivink/mpv-scripts@af360f3. Thus, I've partially restored the variable to fix this. Note: Unlike Sneakpeakcss's version, click-and-drag and point-and-click are mutually exclusive. You can't click to start the crop, then hold-and-drag to select the area. It was unintuitive anyways. Ref: occivink/mpv-scripts#62
dexeonify
pushed a commit
to dexeonify/mpv-config
that referenced
this pull request
Sep 20, 2025
Second take of d5306ca because I noticed Sneakpeakcss didn't fully implement click-and-drag crop selection exactly as in the original PR. Previously, you had to click the first point before you can hold and drag to crop. This commit integrates po5's complex keybinds changes, allowing you to start, select and submit the crop in a single hold-and-drag operation! One of the roadblock to patching po5's PR directly was the condition `or (crop_first_corner.x == corner_video.x and crop_first_corner.y == corner_video.y)`. It was causing errors due to a missing `corner_video` variable, which was removed in occivink/mpv-scripts@af360f3. Thus, I've partially restored the variable to fix this. Note: Unlike Sneakpeakcss's version, click-and-drag and point-and-click are mutually exclusive. You can't click to start the crop, then hold-and-drag to select the area. It was unintuitive anyways. Ref: occivink/mpv-scripts#62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets users hold and drag to select a crop area.
The
window-draggingproperty is temporarily set to no, can be disabled with a script opt.After dragging, releasing left mouse will submit the crop.
It is still possible to do a simple left click to set each crop corner individually.