[CLEANUP] Added different variables to the dataset in order to pass the https://github.com/uw-farlab/cc-plugin-og OG checker #78
+100
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the tests instead!
Collaborator
There was a problem hiding this comment.
DEPLOYMENT_TIME is scalar, same for latitude and longitude.
| # (BLUE WAVELENGTHS) Version 1-05 Document Control Number 1341-00540 2014-05-28. | ||
| ## Observatories Initiative document DATA PRODUCT SPECIFICATION FOR OPTICAL BACKSCATTER | ||
| # Downloaded from https://oceanobservatories.org/wp-content/uploads/2015/10/1341-00540_Data_Product_SPEC_FLUBSCT_OOI.pdf | ||
| BBP_VFTEMP: ### eng_wlbb2f_VFtemp |
Collaborator
There was a problem hiding this comment.
So this is an engineering field. wl = wetlabs (manufacturer). bb2f is something that should mean what the wavelengths are. VFtemp seems like a voltage frequency for the temperature sensor.
| long_name: What is this variable? | ||
| units: Celsius | ||
| observation_type: observed | ||
| TEMP_FREQ: ### eng_tempFreq |
Collaborator
There was a problem hiding this comment.
These are then probably the raw temperature measurements, same for O2freq and condfreq.
| @@ -44,6 +45,10 @@ eng_wlbb2f_blueRef: BBP470_REF | |||
| eng_wlbb2f_blueCount: BBP470 | |||
Collaborator
There was a problem hiding this comment.
Ok! then based on these the "wlbb2f" is a WetLabs EcoPuck with red and blue backscatter and fluorescence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
Checklist:
Related Issues / Pull Requests:
Mainly a fix in the variables naming conventions and including dimensionless variables!
