Skip to content

return the first result for each rule #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-sun-star merged 1 commit into from
Jan 20, 2026
Merged

return the first result for each rule #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/sql-analyzer/analyzer/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,14 @@ func (m *Manager) Analyze(sql string, indexes []model.IndexInfo) []model.SqlDiag
logger.Debugf("[Manager] Rule %s returned %d results", r.Name(), len(results))
if len(results) > 0 {
mu.Lock()
diagnostics = append(diagnostics, results...)
// Only keep the first result for each rule, currently each rule returns the same record, can be enriched to include the detailed sql statement part.
diagnostics = append(diagnostics, results[0])
mu.Unlock()
}
}(rule)
}
wg.Wait()

logger.Debugf("[Manager] Total diagnostics found: %d", len(diagnostics))

return diagnostics
Expand Down