Skip to content

remove unused log in rules #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-sun-star merged 1 commit into from
Jan 27, 2026
Merged

remove unused log in rules #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions internal/sql-analyzer/analyzer/rules/select_all.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
"github.com/antlr4-go/antlr/v4"
"github.com/oceanbase/ob-operator/internal/sql-analyzer/api/model"
obmysql "github.com/oceanbase/ob-operator/internal/sql-analyzer/parser/mysql"
logger "github.com/sirupsen/logrus"
)

// SelectAllRule checks for the usage of SELECT *
Expand Down Expand Up @@ -47,7 +46,6 @@ func (r *SelectAllRule) Description() string {
func (r *SelectAllRule) Analyze(tree antlr.ParseTree, indexes []model.IndexInfo) []model.SqlDiagnoseInfo {
r.diagnoseResults = []model.SqlDiagnoseInfo{} // Reset results for each analysis

logger.Infof("[SelectAllRule] Starting analysis")
// Use ParseTreeWalker to walk the tree with the listener
walker := antlr.NewParseTreeWalker()
walker.Walk(r, tree)
Expand All @@ -58,16 +56,12 @@ func (r *SelectAllRule) Analyze(tree antlr.ParseTree, indexes []model.IndexInfo)
// EnterProjection is called when the listener enters a 'projection' rule.
// Matches: projection : bit_expr | bit_expr AS? column_label | bit_expr AS? STRING_VALUE | Star ;
func (r *SelectAllRule) EnterProjection(ctx *obmysql.ProjectionContext) {
logger.Infof("[SelectAllRule] Entering Projection. Text: %s", ctx.GetText())
if ctx.Star() != nil { // Check if the '*' token exists in this projection context
logger.Infof("[SelectAllRule] Found Star in Projection")
r.diagnoseResults = append(r.diagnoseResults, model.SqlDiagnoseInfo{
RuleName: r.Name(),
Level: "WARN",
Suggestion: "Specify specific columns instead of using SELECT * to improve performance and clarity.",
Reason: "Using SELECT * retrieves all columns, which can be inefficient and return unnecessary data.",
})
} else {
logger.Infof("[SelectAllRule] No Star in Projection")
}
}