Skip to content

fix(task-framework): wrong status when task failed #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guowl3 merged 2 commits into from
Jun 10, 2025
Merged

fix(task-framework): wrong status when task failed #4469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
300598e
rollback correct status
guowl3 Jun 10, 2025
14b22bd
code format
guowl3 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions ...ce/src/main/java/com/oceanbase/odc/service/task/listener/DefaultJobTerminateListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package com.oceanbase.odc.service.task.listener;

import java.text.MessageFormat;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Optional;
Expand Down Expand Up @@ -76,21 +75,10 @@ public void onEvent(JobTerminateEvent event) {
// correct status
TaskStatus taskStatus = TerminateProcessor.correctTaskStatus(terminateProcessors, jobEntity.getJobType(),
scheduleTask, event.getStatus().convertTaskStatus(), event.getTaskResult());
if (scheduleTask.getStatus() != taskStatus) {
// CAS
int affectRows = scheduleTaskService.updateStatusById(scheduleTask.getId(), taskStatus,
Collections.singletonList(scheduleTask.getStatus().name()));
if (affectRows > 0) {
log.info("Update schedule task status from {} to {} succeed,scheduleTaskId={}",
scheduleTask.getStatus(),
taskStatus, scheduleTask.getId());
scheduleTask.setStatus(taskStatus);
} else {
log.info("Update schedule task status from {} to {} failed,scheduleTaskId={}",
scheduleTask.getStatus(),
taskStatus, scheduleTask.getId());
}
}
// correct to final status
scheduleTaskService.updateStatusById(scheduleTask.getId(), taskStatus);
log.info("Update schedule task status to {} succeed,scheduleTaskId={}", taskStatus, scheduleTask.getId());
scheduleTask.setStatus(taskStatus);
// Refresh the schedule status after the task is completed.
scheduleService.refreshScheduleStatus(Long.parseLong(scheduleTask.getJobName()));
// Trigger the alarm if the task is failed or canceled.
Expand Down